docs: add Git notes correcting recent commit messages - #14849
Draft
Planeshifter wants to merge 1 commit into
Draft
docs: add Git notes correcting recent commit messages#14849Planeshifter wants to merge 1 commit into
Planeshifter wants to merge 1 commit into
Conversation
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Contributor
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit of commits merged to
developin the last 24 hours found one commit message with a clear typo. This PR adds a corrected-message note underdocs/git-notes/per the routine's convention; no existing history is rewritten.69174e09: subject typo — "ULP-base assertions" should read "ULP-based assertions" (every sibling commit in the same [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352 migration series uses "ULP-based"). PR-URL, Reviewed-by, and Ref trailers were verified against test: migratestats/base/dists/bernoulli/meanto ULP-base assertions #14832 and [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352 and are correct as-is.All other commits from the last 24 hours were checked (PR-URL/Closes/Ref numbers verified via the GitHub API, trailers checked for malformation, subjects checked for typos and style) and found to be correct.
Checklist